Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix acceptance tests container launching issue #852

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Fix acceptance tests container launching issue #852

merged 2 commits into from
Jul 21, 2023

Commits on Jul 21, 2023

  1. Fix acceptance tests container launching issue 

    A change[1] was backported to golang 1.19 that introduces additional
checks on the `Host` HTTP header. The docker client connecting via
Unix domain socket to the docker daemon does not specify the `Host`
header and that triggers the error `http: invalid Host header`.

The fix[2] was introduced in an unreleased version[3] of docker client
which we use via commit id here to resolve the issue.

[1] golang/go#61075
[2] moby/moby#45935
[3] moby/moby#45971
    @zregvart
    zregvart committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    1c2c185 View commit details
    Browse the repository at this point in the history

  2. Update snapshot file with the new format

    @zregvart
    zregvart committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    db6023e View commit details
    Browse the repository at this point in the history