Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix variable names for building from source distribution #337

Merged
merged 1 commit into from
Dec 23, 2016

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Dec 23, 2016

I received the following error when trying to build from the source 4.6.0 tarball obtained from
https://github.com/enthought/chaco/releases/download/4.6.0/chaco-4.6.0.tar.gz

Traceback (most recent call last):
  File "setup.py", line 133, in <module>
    write_version_py()
  File "setup.py", line 113, in write_version_py
    match = re.match(r'.*?\.dev(?P<dev_num>\d+)', full_v)
NameError: name 'full_v' is not defined

This PR fixes the variable names in this section of setup.py.
Not 100% certain if it should be full_version or fullversion, but I went with the latter as that is what seemed to be used in the other cases.

(Alternately, deleting chaco/_version.py also allows the build to proceed by avoiding this section of setup.py)

@corranwebster
Copy link
Contributor

Thanks for the contribution! This was entirely my fault copy pasting code to get the release out and avoid a different bug in this section.

We'll probably put out a 4.6.1 release shortly to fix the issue.

@corranwebster corranwebster merged commit 649dcb5 into enthought:master Dec 23, 2016
@mdickinson
Copy link
Member

@corranwebster: Did the 4.6.1 release ever make it to PyPI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants