Feature: allow user control over axis title angle #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures unrelated. |
|
@jonathanrocher I will look at this and your other PR asap. |
|
LGTM, code looks good and I played around with the example. (I merged master in this to make sure tests pass). |
|
Thanks for the review @jvkersch ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current code, the axis' title label has an angle fully determined by the orientation of the Axis. left-> 90, right -> 270, top/bottom -> 0.
This PR:
title_angleattribute a Float Trait, and moves its derivation based on orientation to a_title_angle_defaultmethod, so that users can control it.