MAINT: Upcast to int_ instead of int64 to avoid bincount issue. #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itziakos
approved these changes
Oct 31, 2017
|
Thanks @itziakos |
Ouch. Seriously?! Is there an open NumPy issue for that? |
|
@mdickinson This looks like it's related: numpy/numpy#4366 |
jvkersch
added a commit
that referenced
this pull request
Nov 14, 2017
MAINT: Upcast to int_ instead of int64 to avoid bincount issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the computation of the root-mean square function (used in tests to compare generated images with the expectation) to use int_ instead of blanket 64-bit. This came up because the result of the upcast is fed into
np.bincount, which on 32-bit Windows will raise aTypeErrorfor 64-bit inputs.