FIX: Respect visibility in the LegendHighlighter #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwiggins
commented
Mar 30, 2018
| @@ -1,6 +1,5 @@ | |||
| import operator | |||
|
|
|||
| import six | |||
There was a problem hiding this comment.
Unrelated cleanup. This import was not used at all in the file
|
LGTM, although is this the only place where there is this sort of problem? I'm not sure we should do something as drastic as not dispatching events to non-visible components in Enable, but it might be worth a quick audit of other tools. |
|
Thanks for the quick review. Shall I create an issue for the audit of the other tools? |
|
Yes, that would be a good idea. |
jwiggins
added a commit
that referenced
this pull request
Jul 12, 2018
FIX: Respect visibility in the LegendHighlighter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the
LegendHighlightertool would respond to mouse clicks even if the legend was not visible.