Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address DeprecationWarnings #441

Merged
merged 4 commits into from
May 31, 2019
Merged

Address DeprecationWarnings #441

merged 4 commits into from
May 31, 2019

Conversation

jvkersch
Copy link
Contributor

@jvkersch jvkersch commented May 19, 2019 •
edited
Loading

fixes #437

@kitchoi Can you give this a review? Let me know if you have any other warnings popping up.

I haven't looked at the warnings on the C side yet, but I will do so in this PR.

kitchoi
kitchoi reviewed May 29, 2019
View reviewed changes
Copy link
Contributor

@kitchoi kitchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for looking into and fixing this.
I found one potential inconsistency. The rest looks good.

@jvkersch jvkersch merged commit 9f6c463 into master May 31, 2019
@jvkersch jvkersch deleted the maint/deprecation-warnings branch May 31, 2019 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitchoi kitchoi kitchoi left review comments

Assignees

@kitchoi kitchoi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeprecationWarning triggered by downstream package tests
2 participants
@jvkersch @kitchoi