Fix attempts to get the .shape attribute of a list or tuple. #487

mdickinson · 2019-10-30T16:41:27Z

This PR fixes an obvious bug in the LinearMapper code, where we attempt to look up the shape attribute of a list or a tuple.

Code ref:

chaco/chaco/linear_mapper.py

Lines 47 to 50 in e0e4f7d

    
           if isinstance(data_array, (tuple, list, ndarray)): 
        
               x = empty(data_array.shape) 
        
               x.fill(self.low_pos) 
        
               return x

mdickinson · 2019-10-30T16:42:07Z

chaco/horizon_plot.py

@@ -82,7 +80,7 @@ def _render(self, gc, points):
        # Get color bands
        bands = array(self.color_mapper._get_color_bands())

-        with gc: 
+        with gc:


My editor made these fixes, by auto-trimming trailing whitespace. I can revert them if that's preferred.

Fix attempts to get the .shape attribute of a list or tuple.

ef5cc2e

mdickinson commented Oct 30, 2019

View reviewed changes

itziakos approved these changes Oct 30, 2019

View reviewed changes

jvkersch merged commit 021a921 into master Nov 4, 2019

jvkersch deleted the fix/shape-of-list-or-tuple branch November 4, 2019 11:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix attempts to get the .shape attribute of a list or tuple. #487

Fix attempts to get the .shape attribute of a list or tuple. #487

mdickinson commented Oct 30, 2019 •

edited

Loading

mdickinson Oct 30, 2019

	if isinstance(data_array, (tuple, list, ndarray)):
	x = empty(data_array.shape)
	x.fill(self.low_pos)
	return x

Fix attempts to get the .shape attribute of a list or tuple. #487

Fix attempts to get the .shape attribute of a list or tuple. #487

Conversation

mdickinson commented Oct 30, 2019 • edited Loading

mdickinson Oct 30, 2019

Choose a reason for hiding this comment

mdickinson commented Oct 30, 2019 •

edited

Loading