-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing property index_range to 1D plots #491
Conversation
All python 3.6 CI builds are failing at the setup stage with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor nits.
Also there isn't a direct test of setting the index_range
trait, only a second-order test of changing the index range of a Plot
. It probably makes sense to add a setting test to the test case, and possibly a test that when you change the index_mapper
that the index_range
fires a trait change and is updated as expected (whether you do this depends on how much you trust the traits internals :) ).
I've addressed the comments.
I didn't have a module-level listener on I made a drive-by style fix: all test functions were called "*scatter_" even for non-scatter plot modules. Since it may be off-topic, I committed it separately (cdd3cc7) to be able to revert it. |
Thanks, I didn't know about the mixin. I've made the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds a
index_range
property, synonym ofindex_mapper.range
, toBase1DPlot
. This corresponds to a similarly defined property inBase2DPlot
, andPlot._handle_range_changed()
expects this attribute to exist in order to work properly.+ new assertions for regression testing.
Closes #490