Fix stacked bar plot example, by using the correct starting_value #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,7 +47,7 @@ def __init__(self, index, series_a, series_b, series_c, **kw): | |||
|
|
|||
|
|
|||
| index = numpy.array([1,2,3,4,5]) | |||
| demo = PlotExample(index, index*10, index*5, index*2) | |||
| demo = PlotExample(index, index*10, index*15, index*17) | |||
There was a problem hiding this comment.
Is it not possible to do this without changing the input data?
There was a problem hiding this comment.
Docstring for starting_value says the following:
#: The data source to use as "starting" values for bars (along value axis).
#: For instance, if the values are [10, 20] and starting_value
#: is [3, 7], BarPlot will plot two bars, one between 3 and 10, and
#: one between 7 and 20
I think BarPlot is designed not to change the value when stacking, so the user may have to do it explicitly.
There was a problem hiding this comment.
You could reverse the input data instead. The original version of this relied on the rendering order (the tallest bar was drawn first, etc.).
Even better might be to sum the data as part of the process of creating the plots (ie. barplot 1 is from 0 to series_a, barplot 2 is from series_a to series_a + series_b, etc.)
There was a problem hiding this comment.
Agreed, that's better, made the change.
corranwebster
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #444