Do not expose 'auto' for infinite series #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulporuri
reviewed
Dec 30, 2019
examples/demo/functionplotter.py
Outdated
| traits_view = View( | ||
| Group( | ||
| Item('plot', editor=ComponentEditor(), show_label=False), | ||
| HGroup( | ||
| HGroup( | ||
| Item('object.plot.x_mapper.range.low_setting', label='Low'), | ||
| Item('object.plot.x_mapper.range.high_setting', label='High'), | ||
| Item('object.plot.x_mapper.range.low_setting', label='Low', editor=TextEditor(), visible_when='object.low_mode == "value" ', ), |
There was a problem hiding this comment.
I'm probably being very nitpicky and i apologize for it in advance.
Can you conform to the usual line length limits? We probably don't enforce line length limits in the codebase in general, if not the examples scripts specifically but IMO it's always a good idea to maintain standards (because examples is what other will learn from).
There was a problem hiding this comment.
You're right. Will conform to line length for this and future changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416