remove Serializable mixin and related code #575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulporuri
reviewed
Mar 22, 2021
chaco/grid.py
Outdated
| @@ -407,8 +407,6 @@ def _orientation_changed(self): | |||
|
|
|||
|
|
|||
| ### Persistence ########################################################### | |||
| #_pickles = ("orientation", "line_color", "line_style", "line_weight", | |||
| # "grid_interval", "mapper") | |||
|
|
|||
| def __getstate__(self): | |||
There was a problem hiding this comment.
I don't know if the __getstate__ methods can also be thrown out if the serialization code is being thrown out.
|
closing in favor of #598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #250
This PR removes the
Serializablemixin class and related tests. It also removes any definitions of a_post_loadmethod in various classes as the only place I saw it originally defined / used wasSerializable(including a search of enable and traits).