Replace dynamic on_trait_change with observe part 2 #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tter_inspector_overlay.py
…/scatter_inspector_overlay.py
aaronayres35
commented
Apr 2, 2021
| old + "_mapper", remove=True) | ||
| if new is not None: | ||
| self.plot.on_trait_change(self.__mapper_changed, | ||
| old + "_mapper", remove=True) |
There was a problem hiding this comment.
This previous code seems like it was a copy paste error...
Butt the updated code is still not right ad we have a case in the test suite where old is non None, but its listener never was hooked up initially
rahulporuri
approved these changes
Apr 2, 2021
Comment on lines
42
to
43
| # using a series of trait change handlers (defined at the end of the | ||
| # class) |
There was a problem hiding this comment.
This is tangential but i want to dig a little and find the source of this comment - it looks like there was going to be some fancy traits feature which would remove unnecessary code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues replacing the dynamic uses of on_trait_change with observe equivalents on top of #590