Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "chaco.scatter_markers" module #677

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

rahulporuri
Copy link
Contributor

This PR removes the chaco.scatter_markers module and updates one import in chaco to use enable.api instead. The file is also removed from the list of ignored files for flake8.

As can be seen from the module docstring, the contents of this module were moved to enable so the imports should also be updated to use enable.

and update one import in chaco to use enable.api instead
and remove it from the list of ignored flake8 files

	deleted:    chaco/scatter_markers.py
	modified:   chaco/tools/cursor_tool.py
	modified:   tox.ini
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri merged commit 1794816 into master Apr 16, 2021
@rahulporuri rahulporuri deleted the cln/remove-scatter-markers-module branch April 16, 2021 13:29
@aaronayres35
Copy link
Contributor

ref #580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants