Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom "assert_raises" with "unittest.TestCase.assertRaises" #705

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Replace custom "assert_raises" with "unittest.TestCase.assertRaises" #705

merged 1 commit into from
Apr 21, 2021

Conversation

rahulporuri
Copy link
Contributor

This PR replaces the use of the custom assert_raises context manager with the unittest.TestCase.assertRaises and removes the custom assert_raises context manager.

CLN : Replace custom assert_raises with unittest.TestCase.assertRaises
733e891 
	modified:   chaco/tests/_tools.py
	modified:   chaco/tests/test_2d_case.py
aaronayres35
aaronayres35 approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri merged commit 75631e1 into master Apr 21, 2021
@rahulporuri rahulporuri deleted the cln/remove-custom-assert-raises branch April 21, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronayres35 aaronayres35 aaronayres35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulporuri @aaronayres35