Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix of chaco.axis #773

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Backport fix of chaco.axis #773

merged 1 commit into from
Jun 10, 2021

Conversation

aaronayres35
Copy link
Contributor

This had been broken in PR #743 and was recently fixed on the maint/5.0 branch. This PR simply pulls that fix back up into master

…ault value of None for component. Similarly _compute_tick_positions has a default value of None for other_component. In this case we can just not pass anything as it should be None (#772)
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronayres35 aaronayres35 merged commit 2075321 into master Jun 10, 2021
@aaronayres35 aaronayres35 deleted the backport-fix-axis branch June 10, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants