Fix CursorTool issue with LogMapper #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulporuri
approved these changes
Jun 29, 2021
|
Ah, similara to #804, this PR currently just makes a switch from one assumption to another. ie with the changes here, now the CursorTool will not work with LinearMappers. I will update the PR |
aaronayres35
commented
Jun 29, 2021
chaco/plots/lineplot.py
Outdated
| @@ -122,7 +122,7 @@ def hittest(self, screen_pt, threshold=7.0, return_distance=False): | |||
| # screen_pt is one of the points in the lineplot | |||
| data_pt = (self.index.get_data()[ndx], self.value.get_data()[ndx]) | |||
| if return_distance: | |||
| scrn_pt = self.map_screen(data_pt) | |||
| scrn_pt = self.map_screen(data_pt)[0] | |||
There was a problem hiding this comment.
Note this change is also made in #802
Both the changes to BaseXYPlot1.map_screen done there and LinearMapper.map_screen here can cause the return type to be an an array of shape (N,2).
|
Unfortunately a lot of these changes are some what related. The changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #289
This PR pulls the content specific to #289 out from PR #726