Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MappedUnion and Optional traits and use Optional where appropriate #838

Merged
merged 8 commits into from
Oct 25, 2022
Merged

Add MappedUnion and Optional traits and use Optional where appropriate #838

merged 8 commits into from
Oct 25, 2022

Commits on Oct 14, 2022

  1. Add MappedUnion and Optional traits and use Optional where appropriate.

    @corranwebster
    corranwebster committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    4449274 View commit details
    Browse the repository at this point in the history

  2. Remove unneeded Union imports

    @corranwebster
    corranwebster committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    e6b4af0 View commit details
    Browse the repository at this point in the history

  3. Skip None when looking for mapped traits.

    @corranwebster
    corranwebster committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    d42ce32 View commit details
    Browse the repository at this point in the history

  4. Fix overeager use of Optional()

    @corranwebster
    corranwebster committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    51c3182 View commit details
    Browse the repository at this point in the history

  5. Fix Union() usage correctly!

    @corranwebster
    corranwebster committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    b24bc92 View commit details
    Browse the repository at this point in the history

  6. Fixed the wrong trait in plot_container.py

    @corranwebster
    corranwebster committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    7d585b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Add tests and some minor tweaks coming from tests.

    @corranwebster
    corranwebster committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    76d7587 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Change based on PR review comments.

    @corranwebster
    corranwebster committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    47ada7d View commit details
    Browse the repository at this point in the history