Image size fix #882
Merged
Image size fix #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
reviewed
Apr 4, 2023
| @@ -38,8 +38,8 @@ def __init__(self): | |||
| self.renderer = plot.img_plot( | |||
| "imagedata", | |||
| name="plot1", | |||
| xbounds=xgrid, | |||
| ybounds=ygrid, | |||
| xbounds=(0, 6), | |||
There was a problem hiding this comment.
Why are the bounds given as 0 and 6 when x goes from 0 to 8?
There was a problem hiding this comment.
Yeah, it should be the other way around... Just fixed
dpinte
approved these changes
Apr 6, 2023
corranwebster
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue #867
The demo chaco/examples/tutorials/scipy2008/traits_image.py is broken as mentioned in the issue.
Since this is a very early example (2008), it's likely some updates in chaco has broken this demo. I found that all recent calls to img_plot (line 678, chaco/chaco/plot.py) uses a range other than mash for xbounds and ybounds since plot._process_2d_bounds will regenerate the mash with the range that has the correct dimension. Thus I change this example to use a range other than a mesh as well.