Skip to content

Commit

Permalink
Add Windows to the GitHub Actions CI test matrix (#539)
Browse files Browse the repository at this point in the history
* Add Windows, expect a test to fail due to screen size

* Remove unreliable assertion, it fails when the host machine is different

* Clarify comment
  • Loading branch information
kitchoi authored Jan 12, 2021
1 parent c5bc48e commit d4c961c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/test-with-edm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,15 @@ jobs:
test-with-edm:
strategy:
matrix:
os: [macos-latest]
os: [macos-latest, windows-latest]
toolkit: ['pyqt', 'pyqt5', 'pyside2', 'wx']
runs-on: ${{ matrix.os }}
env:
# Set root directory, mainly for Windows, so that the EDM Python
# environment lives in the same drive as the cloned source. Otherwise
# 'pip install' raises an error while trying to compute
# relative path between the site-packages and the source directory.
EDM_ROOT_DIRECTORY: ${{ github.workspace }}/.edm
steps:
- uses: actions/checkout@v2
- name: Cache EDM packages
Expand Down
4 changes: 0 additions & 4 deletions enable/tests/test_component_editor.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,5 @@ def test_initial_component_with_item_size(self):

size = get_dialog_size(ui.control)

# leave a few pixel of margin for wx
self.assertGreater(size[0], ITEM_WIDTH-1)
self.assertLess(size[0], ITEM_WIDTH+30)

self.assertGreater(size[1], ITEM_HEIGHT-1)
self.assertLess(size[1], ITEM_HEIGHT+30)

0 comments on commit d4c961c

Please sign in to comment.