Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

please remove usages of the numpy/oldnumeric.h header #1005

Closed
rgommers opened this issue Nov 11, 2022 · 1 comment · Fixed by #1011
Closed

please remove usages of the numpy/oldnumeric.h header #1005

rgommers opened this issue Nov 11, 2022 · 1 comment · Fixed by #1011
Labels
component: build Issues related to build and infrastructure difficulty: advanced priority: high type: refactor

Comments

@rgommers
Copy link

There are 4 instances of using this header left in this repo. It will be removed from NumPy at some point. I was looking at this because we're doing a build system migrating in NumPy - that will land in NumPy 1.25.0 (mid 2023)
@corranwebster
Copy link
Contributor

Thanks for reporting this. 3 of the 4 uses are in code that we are hoping to deprecate, but the 4th is in a module that we'd like to continue supporting, so we'll aim to update for the next release.

@corranwebster corranwebster mentioned this issue Feb 16, 2023
Merged
3 tasks
corranwebster added a commit that referenced this issue May 5, 2023
@corranwebster
Remove support for Numeric (as opposed to NumPy) from Kiva (#1011)
0ae01f0 
It turns out there was some code that was available to support, and some that used, the Numeric C API (ie. the predecessor to NumPy). The compatibility headers that NumPy provided to help with this are going away, so this PR removes all uses of Numeric code.

Fixes #1005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: build Issues related to build and infrastructure difficulty: advanced priority: high type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove support for Numeric (as opposed to NumPy) from Kiva enthought/enable
2 participants
@rgommers @corranwebster