Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs and examples to the source distribution #214

Merged
merged 2 commits into from
Apr 29, 2016
Merged

Conversation

jwiggins
Copy link
Member

Fixes #213

@jonathanrocher
Copy link
Contributor

I tried to build the html docs yesterday from the sdist I generated, and failed with the following error because of the way conf.py looks for enable's __init__:

$ make html
sphinx-build -b html -d build/doctrees   source build/html
Running Sphinx v1.2.3

Exception occurred:
  File "../../enable/__init__.py", line 6, in <module>
ImportError: cannot import name full_version
The full traceback has been saved in /var/folders/ff/z56qhb_936g8xx3rzm1_1r800000gp/T/sphinx-err-gn5R7X.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://bitbucket.org/birkenfeld/sphinx/issues/>. Thanks!
make: *** [html] Error 1

We may want to fix that in conf.py...

@jwiggins
Copy link
Member Author

jwiggins commented Oct 1, 2015

Nice catch @jonathanrocher. I've changed conf.py over to enable/_version.py and it appears to work.

@corranwebster corranwebster merged commit c6849e1 into master Apr 29, 2016
@corranwebster corranwebster deleted the fix/sdist branch April 29, 2016 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants