Remove support for Mac font suitcases. #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 52.05% (diff: 66.66%)@@ master #244 diff @@
==========================================
Files 126 126
Lines 13190 13176 -14
Methods 0 0
Messages 0 0
Branches 1948 1943 -5
==========================================
Hits 6859 6859
+ Misses 5885 5872 -13
+ Partials 446 445 -1
|
|
LGTM, although in the grand scheme of things we probably would be better off if we didn't have a vendorised 8+ year old version of fonttools (https://pypi.python.org/pypi/FontTools) bundled up into Enable. |
|
@corranwebster: Do you think we can/should switch to a non-vendorized version? This would be something to think about post-release, of course |
|
@jwiggins I have no idea: I haven't looked into it at all. The likelihood of success will probably be based on how much the code has been modified. If its just bugfixes and styling, it may just be a matter of fixing up imports. |
|
@mdickinson: LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes Mac-only support for font suitcases. That support was enabled only for classic Mac OS, and depends on the
macfsstd. lib. module, which doesn't exist in Python 3.