Kiva explorer demo #246
Merged
Kiva explorer demo #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 52.65% (diff: 100%)@@ master #246 diff @@
==========================================
Files 126 126
Lines 13190 13521 +331
Methods 0 0
Messages 0 0
Branches 1948 2068 +120
==========================================
+ Hits 6859 7120 +261
- Misses 5885 5932 +47
- Partials 446 469 +23
|
|
😍 Bless you, sir. This is exactly what I need right now. I should probably push my pyagg backend branch, huh? |
|
Just a quick read from my end, but LGTM |
|
You're welcome! And since this is non-critical code, I shall merge it. |
|
It would be useful to have something that printed out the rendering time on this... (per render and frames per second) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a really simple traitsui view for playing with Kiva.