Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Qt mouse button names #345

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Add more Qt mouse button names #345

merged 1 commit into from
Jun 3, 2019

Conversation

jwiggins
Copy link
Member

@jwiggins jwiggins commented May 30, 2019

Fixes #334

@codecov-io
Copy link

codecov-io commented May 30, 2019

Codecov Report

Merging #345 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   33.94%   33.94%           
=======================================
  Files         206      206           
  Lines       18290    18290           
  Branches     2414     2414           
=======================================
  Hits         6209     6209           
  Misses      11688    11688           
  Partials      393      393
Impacted Files Coverage Δ
enable/qt4/constants.py 90.47% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768e791...9c350b1. Read the comment docs.

@jwiggins
Copy link
Member Author

jwiggins commented Jun 1, 2019

@corranwebster Care to comment on the names I picked for the buttons?

@corranwebster
Copy link
Contributor

Names look fine to me - I've never had a 5 button mouse, but that seems consistent usage with searches.

@jwiggins jwiggins merged commit 0a226da into master Jun 3, 2019
@jwiggins
Copy link
Member Author

jwiggins commented Jun 3, 2019

Thanks for the review!

@jwiggins jwiggins deleted the fix/qt-mouse-buttons branch June 3, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qt4 BUTTON_NAME_MAP is missing entries
3 participants