-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warnings due to escape characters #371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Right, these are annoying to track down because (unlike most other warnings) they're triggered at compile time - i.e., .pyc-file generation time. If you remove the .pyc files and try again, you should see the warnings reappear. |
FWIW, |
Here's what I see from
|
That makes sense. Thanks. I can go over all these occurrences and update them all as it is well within scope for this PR, then request review again. Does this sound good? |
SVGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and I confirm that I no longer see any W605 flake8 warnings on this branch on my machine.
Thank you! Merging... |
This PR fixes deprecation warnings while running a test suite in a downstream project depending on enable.
It is not easy to pin point exactly where this gets trigger: I believe this is triggered by some import side-effects and the warning only appears once after every time my Python environment is rebuilt.
For example:
Running the command again does not trigger the warnings.