-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maint: add Container.components setter. #387
Conversation
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
=======================================
Coverage 32.73% 32.73%
=======================================
Files 206 206
Lines 18297 18297
Branches 2470 2470
=======================================
Hits 5990 5990
Misses 11929 11929
Partials 378 378
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Perhaps a small test to exercise getting and setting components?
Thanks for approving the change @jvkersch . I added a unit test to exercise the setter. Further comments/reviews welcome. |
This has been sitting approved for a while, so I will merge soon unless there are more comments. |
In Chaco's implementation of the
BasePlotContainer
, a warning states that getting or settingplot_components
is deprecated, and components should be used instead. But enable'sContainer
class doesn't have a setter for thecomponents
property.This PR corrects that.