Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maint: add Container.components setter. #387

Merged
merged 4 commits into from
Mar 11, 2020

Conversation

jonathanrocher
Copy link
Contributor

@jonathanrocher jonathanrocher commented Feb 7, 2020

In Chaco's implementation of the BasePlotContainer, a warning states that getting or setting plot_components is deprecated, and components should be used instead. But enable's Container class doesn't have a setter for the components property.

This PR corrects that.

@jonathanrocher jonathanrocher changed the title Add components property setter. Maint: add Container.components setter. Feb 7, 2020
@codecov-io
Copy link

codecov-io commented Feb 7, 2020

Codecov Report

Merging #387 into master will not change coverage.
The diff coverage is 70.58%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #387   +/-   ##
=======================================
  Coverage   32.73%   32.73%           
=======================================
  Files         206      206           
  Lines       18297    18297           
  Branches     2470     2470           
=======================================
  Hits         5990     5990           
  Misses      11929    11929           
  Partials      378      378
Impacted Files Coverage Δ
enable/trait_defs/rgba_color_trait.py 0% <ø> (ø) ⬆️
enable/savage/trait_defs/ui/qt4/svg_editor.py 0% <0%> (ø) ⬆️
kiva/fonttools/font_manager.py 50.59% <92.3%> (ø) ⬆️
enable/toolkit_constants.py 100% <0%> (ø) ⬆️
enable/qt4/constants.py 90.47% <0%> (ø) ⬆️
enable/qt4/scrollbar.py 77.22% <0%> (ø) ⬆️
enable/qt4/image.py 75% <0%> (ø) ⬆️
kiva/qpainter.py 51.07% <0%> (ø) ⬆️
enable/qt4/base_window.py 51.07% <0%> (ø) ⬆️
enable/component_editor.py 79.16% <0%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f241ee...3ee3dc2. Read the comment docs.

Copy link
Contributor

@jvkersch jvkersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Perhaps a small test to exercise getting and setting components?

@jonathanrocher
Copy link
Contributor Author

Thanks for approving the change @jvkersch . I added a unit test to exercise the setter. Further comments/reviews welcome.

@jonathanrocher
Copy link
Contributor Author

This has been sitting approved for a while, so I will merge soon unless there are more comments.

@jonathanrocher jonathanrocher merged commit 6cf525c into master Mar 11, 2020
@jonathanrocher jonathanrocher deleted the maint/add_container_components_setter branch March 11, 2020 21:55
kitchoi added a commit that referenced this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants