Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for Examples #388

Merged
merged 1 commit into from
Feb 16, 2020
Merged

Small fixes for Examples #388

merged 1 commit into from
Feb 16, 2020

Conversation

corranwebster
Copy link
Contributor

This PR fixes a couple of small issues found when working with the examples:

  • the savage static demo didn't work on Python 3 because the XML writer expected bytes, not str.
  • error reporting was broken in the KivaExplorer, and the timing editor was an editable field.

This fixes both issues.

@codecov-io
Copy link

codecov-io commented Feb 15, 2020

Codecov Report

Merging #388 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   32.73%   32.73%           
=======================================
  Files         206      206           
  Lines       18297    18297           
  Branches     2470     2470           
=======================================
  Hits         5990     5990           
  Misses      11929    11929           
  Partials      378      378
Impacted Files Coverage Δ
enable/savage/trait_defs/ui/qt4/svg_editor.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6e7664...c96cc8a. Read the comment docs.

@corranwebster corranwebster merged commit 418ce8e into master Feb 16, 2020
@corranwebster corranwebster deleted the fix/various-small-fixes branch February 16, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants