Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make python 3.6 defualt runtime for click options instead of 3.5 #430

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

aaronayres35
Copy link
Contributor

fixes #429

This PR simply bumps the runtime option default from 3.5 to 3.6 as 3.6 is what is listed in supported_combinations

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also update the docstring at the top of the module? The docstring still refers to 2.7 and 3.5 as the supported runtimes.

@aaronayres35
Copy link
Contributor Author

LGTM. Can you also update the docstring at the top of the module? The docstring still refers to 2.7 and 3.5 as the supported runtimes.

I also change the docstring to say "currently supported toolkits are null, pyqt, and pyqt5" instead of "currently supported toolkits are null, pyqt, and wx" and wx is also not a part of supported_combinations atm.

@aaronayres35
Copy link
Contributor Author

LGTM. Can you also update the docstring at the top of the module? The docstring still refers to 2.7 and 3.5 as the supported runtimes.

I also change the docstring to say "currently supported toolkits are null, pyqt, and pyqt5" instead of "currently supported toolkits are null, pyqt, and wx" and wx is also not a part of supported_combinations atm.

seems wx support was lost here: #384 . Should we open an issue to re-add wx support/ re-add it to CI?

@rahulporuri
Copy link
Contributor

seems wx support was lost here: #384 . Should we open an issue to re-add wx support/ re-add it to CI?

we definitely should. I think there is a PR open that tries fixing the wx support.

@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #430 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   28.92%   28.92%           
=======================================
  Files         206      206           
  Lines       18246    18246           
  Branches     2466     2466           
=======================================
  Hits         5278     5278           
  Misses      12641    12641           
  Partials      327      327           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 375d52e...4816fed. Read the comment docs.

@aaronayres35
Copy link
Contributor Author

seems wx support was lost here: #384 . Should we open an issue to re-add wx support/ re-add it to CI?

we definitely should. I think there is a PR open that tries fixing the wx support.

ah my mistake, it is still run on CI just as an allowed failure. We still would want to fix that/ add it back to the supported_combinations though

@aaronayres35 aaronayres35 merged commit 9756ec1 into master Oct 26, 2020
@rahulporuri rahulporuri deleted the update-default-runtime branch October 27, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default runtime in edmtool.py is 3.5
3 participants