-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make python 3.6 defualt runtime for click options instead of 3.5 #430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you also update the docstring at the top of the module? The docstring still refers to 2.7
and 3.5
as the supported runtimes.
I also change the docstring to say "currently supported toolkits are |
seems wx support was lost here: #384 . Should we open an issue to re-add wx support/ re-add it to CI? |
we definitely should. I think there is a PR open that tries fixing the wx support. |
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
=======================================
Coverage 28.92% 28.92%
=======================================
Files 206 206
Lines 18246 18246
Branches 2466 2466
=======================================
Hits 5278 5278
Misses 12641 12641
Partials 327 327 Continue to review full report at Codecov.
|
ah my mistake, it is still run on CI just as an allowed failure. We still would want to fix that/ add it back to the supported_combinations though |
fixes #429
This PR simply bumps the runtime option default from 3.5 to 3.6 as 3.6 is what is listed in
supported_combinations