Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python version checks #463

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Conversation

aaronayres35
Copy link
Contributor

part of #415

This PR removes any explicit python version checks and only keeps the code paths that are specific to python versions we plan to continue to support (python >=3.6).

Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments

enable/tests/primitives/test_image.py Outdated Show resolved Hide resolved
kiva/fonttools/font.py Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Dec 4, 2020

Codecov Report

Merging #463 (be9d0ff) into master (4db18d2) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
- Coverage   30.33%   30.20%   -0.13%     
==========================================
  Files         206      206              
  Lines       18245    18185      -60     
  Branches     2466     2465       -1     
==========================================
- Hits         5534     5493      -41     
+ Misses      12371    12353      -18     
+ Partials      340      339       -1     
Impacted Files Coverage Δ
kiva/fonttools/font.py 47.43% <ø> (+0.52%) ⬆️
enable/primitives/box.py 32.00% <0.00%> (-2.62%) ⬇️
enable/wx/constants.py 55.55% <0.00%> (-2.34%) ⬇️
enable/primitives/annotater.py 32.50% <0.00%> (-1.65%) ⬇️
enable/primitives/line.py 33.33% <0.00%> (-1.29%) ⬇️
enable/graphics_context.py 30.35% <0.00%> (-1.23%) ⬇️
enable/tools/apptools/command_tool.py 84.61% <0.00%> (-1.10%) ⬇️
enable/compass.py 29.26% <0.00%> (-0.86%) ⬇️
enable/canvas.py 26.59% <0.00%> (-0.78%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4db18d2...be9d0ff. Read the comment docs.

Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

@aaronayres35 aaronayres35 merged commit b2dba1d into master Dec 4, 2020
@jwiggins jwiggins deleted the remove-python-version-checks branch December 4, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants