Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove commented out code #466

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Remove commented out code #466

merged 1 commit into from
Dec 4, 2020

Conversation

aaronayres35
Copy link
Contributor

This PR simply removes a bunch of commented out code from the code base. There is certainly more that should be removed still floating around

@codecov-io
Copy link

codecov-io commented Dec 3, 2020 •
edited
Loading

Codecov Report

Merging #466 (e0f5534) into master (4db18d2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #466   +/-   ##
=======================================
  Coverage   30.33%   30.33%           
=======================================
  Files         206      206           
  Lines       18245    18245           
  Branches     2466     2466           
=======================================
  Hits         5534     5534           
  Misses      12371    12371           
  Partials      340      340
Impacted Files Coverage Δ
enable/pyglet_backend/window.py 0.00% <ø> (ø)
enable/savage/compliance/viewer.py 0.00% <ø> (ø)
enable/savage/svg/document.py 27.04% <ø> (ø)
enable/stacked_layout.py 0.00% <ø> (ø)
enable/vtk_backend/vtk_window.py 0.00% <ø> (ø)
kiva/cairo.py 0.00% <ø> (ø)
kiva/pdfmetrics.py 19.79% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4db18d2...e0f5534. Read the comment docs.

jwiggins
jwiggins approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@aaronayres35 aaronayres35 merged commit 806dfd0 into master Dec 4, 2020
@jwiggins jwiggins deleted the remove-dead-code branch December 4, 2020 13:33
rahulporuri pushed a commit that referenced this pull request Apr 16, 2021
FIX : Handle case when container.resizable is none
0c9288e 
it looks like these lines were commented out from the original commit when
this code was added to enable in 75fb3ac
and subsequently, the commented out code was removed in the PR
#466
@rahulporuri rahulporuri mentioned this pull request Apr 16, 2021
Merged
rahulporuri pushed a commit that referenced this pull request Apr 26, 2021
Handle preferred size computation when container isnt resizable (#778)
7b45517 
* DOC : Remove now outdated comment string

Ref https://github.com/enthought/chaco/pull/673/files

* FIX : Handle case when container.resizable is none

it looks like these lines were commented out from the original commit when
this code was added to enable in 75fb3ac
and subsequently, the commented out code was removed in the PR
#466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwiggins jwiggins jwiggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronayres35 @codecov-io @jwiggins