Remove USE_FONTCONFIG in font_manager #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwiggins
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
LGTM.
I was about to suggest that importing the module and changing the value of USE_FONTCONFIG would give the ability to run this code path, but even that's not possible.
I assume you still want to remove findfont, but didn't want to mix it up with this change?
Yes I do. It was very tempting though. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The USE_FONTCONFIG is a module level constant to be flipped to change the behaviour of
kiva.fonttools.font_managerat import time. It is hard to see how this can be used apart from running the file as a script.This PR removes code that is never run due to the fact that
USE_FONTCONFIGis false.