Clean-up a couple demos #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwiggins
reviewed
Dec 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #511 +/- ##
=======================================
Coverage 30.71% 30.71%
=======================================
Files 210 210
Lines 17840 17840
Branches 2454 2454
=======================================
Hits 5479 5479
Misses 12028 12028
Partials 333 333 Continue to review full report at Codecov.
|
aaronayres35
commented
Dec 21, 2020
|
|
||
| if __name__ == "__main__": | ||
| demo_main(MyFrame) | ||
| demo_main(Demo) |
There was a problem hiding this comment.
This example still doesn't seem to be working as it is supposed to (I'm not seeing a context menu). These changes just allow it to run and run in etsdemo in its current state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up a couple demos by using absolute imports, using magically named
Demo, and over writing_create_componentinstead of_create_windowso that these demos can be run / run smoothly through the etsdemo application