Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset 2to3 flag from setup file #520

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Unset 2to3 flag from setup file #520

merged 1 commit into from
Dec 30, 2020

Conversation

rahulporuri
Copy link
Contributor

Now that we don't have any Python 2 code, we can simply remove the use_2to3 boolean flag in setup. Note that we werent using 2to3 in the recent release anyway.

Now that we don't have any Python 2 code, we can simply
remove the `use_2to3` boolean flag in setup. Note that we werent
using 2to3 earlier anyway.
@codecov-io
Copy link

codecov-io commented Dec 30, 2020

Codecov Report

Merging #520 (3968f1b) into master (5834fb8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #520   +/-   ##
=======================================
  Coverage   35.16%   35.16%           
=======================================
  Files         210      210           
  Lines       17840    17840           
  Branches     2454     2454           
=======================================
  Hits         6274     6274           
  Misses      11161    11161           
  Partials      405      405           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5834fb8...3968f1b. Read the comment docs.

Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri merged commit 9244eae into master Dec 30, 2020
@rahulporuri rahulporuri deleted the rahulporuri-patch-1 branch December 30, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants