Address resource warnings because of open file handles #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saving the graphics context to the PS and SVG backends raises resource warnings because the file handler is not closed by the save method. This is a trivial fix by using open as a context manager modified: kiva/ps.py modified: kiva/svg.py
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
=======================================
Coverage 35.16% 35.16%
=======================================
Files 210 210
Lines 17840 17840
Branches 2454 2454
=======================================
Hits 6274 6274
Misses 11161 11161
Partials 405 405
Continue to review full report at Codecov.
|
jwiggins
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
LGTM. Note that the GL tests still have this problem:
home/travis/.edm/envs/enable-test-3.6-pyqt/lib/python3.6/site-packages/kiva/tests/test_gl_drawing.py:55: ResourceWarning: unclosed file <_io.BufferedWriter name='/tmp/tmp7nfmc1i8/rendered.png'>
buffer.get_color_buffer().save(filename, encoder=PNGImageEncoder())
ok
test_circle_clip (kiva.tests.test_gl_drawing.TestGLDrawing) ... /home/travis/.edm/envs/enable-test-3.6-pyqt/lib/python3.6/site-packages/kiva/tests/test_gl_drawing.py:55: ResourceWarning: unclosed file <_io.BufferedWriter name='/tmp/tmpg1f78hpl/rendered.png'>
buffer.get_color_buffer().save(filename, encoder=PNGImageEncoder())
ok
test_circle_fill (kiva.tests.test_gl_drawing.TestGLDrawing) ... /home/travis/.edm/envs/enable-test-3.6-pyqt/lib/python3.6/site-packages/kiva/tests/test_gl_drawing.py:55: ResourceWarning: unclosed file <_io.BufferedWriter name='/tmp/tmpp13utc14/rendered.png'>
buffer.get_color_buffer().save(filename, encoder=PNGImageEncoder())
ok
test_line (kiva.tests.test_gl_drawing.TestGLDrawing) ... /home/travis/.edm/envs/enable-test-3.6-pyqt/lib/python3.6/site-packages/kiva/tests/test_gl_drawing.py:55: ResourceWarning: unclosed file <_io.BufferedWriter name='/tmp/tmp61yj939u/rendered.png'>
buffer.get_color_buffer().save(filename, encoder=PNGImageEncoder())
ok
test_quarter_circle (kiva.tests.test_gl_drawing.TestGLDrawing) ... /home/travis/.edm/envs/enable-test-3.6-pyqt/lib/python3.6/site-packages/kiva/tests/test_gl_drawing.py:55: ResourceWarning: unclosed file <_io.BufferedWriter name='/tmp/tmpih3jrfhr/rendered.png'>
buffer.get_color_buffer().save(filename, encoder=PNGImageEncoder())
ok
test_rect (kiva.tests.test_gl_drawing.TestGLDrawing) ... /home/travis/.edm/envs/enable-test-3.6-pyqt/lib/python3.6/site-packages/kiva/tests/test_gl_drawing.py:55: ResourceWarning: unclosed file <_io.BufferedWriter name='/tmp/tmp0h8fty3k/rendered.png'>
buffer.get_color_buffer().save(filename, encoder=PNGImageEncoder())
ok
test_rectangle (kiva.tests.test_gl_drawing.TestGLDrawing) ... /home/travis/.edm/envs/enable-test-3.6-pyqt/lib/python3.6/site-packages/kiva/tests/test_gl_drawing.py:55: ResourceWarning: unclosed file <_io.BufferedWriter name='/tmp/tmpnk4i1tug/rendered.png'>
buffer.get_color_buffer().save(filename, encoder=PNGImageEncoder())
ok
test_star_clip (kiva.tests.test_gl_drawing.TestGLDrawing) ... skipped 'gl graphics context does not support star_clip (#164)'
test_star_eof_fill (kiva.tests.test_gl_drawing.TestGLDrawing) ... /home/travis/.edm/envs/enable-test-3.6-pyqt/lib/python3.6/site-packages/kiva/tests/test_gl_drawing.py:55: ResourceWarning: unclosed file <_io.BufferedWriter name='/tmp/tmpdr6zooxm/rendered.png'>
buffer.get_color_buffer().save(filename, encoder=PNGImageEncoder())
ok
test_star_fill (kiva.tests.test_gl_drawing.TestGLDrawing) ... /home/travis/.edm/envs/enable-test-3.6-pyqt/lib/python3.6/site-packages/kiva/tests/test_gl_drawing.py:55: ResourceWarning: unclosed file <_io.BufferedWriter name='/tmp/tmpl7q3qpkr/rendered.png'>
buffer.get_color_buffer().save(filename, encoder=PNGImageEncoder())
ok
test_text (kiva.tests.test_gl_drawing.TestGLDrawing) ... /home/travis/.edm/envs/enable-test-3.6-pyqt/lib/python3.6/site-packages/kiva/tests/test_gl_drawing.py:55: ResourceWarning: unclosed file <_io.BufferedWriter name='/tmp/tmp5l_oqzlg/rendered.png'>
buffer.get_color_buffer().save(filename, encoder=PNGImageEncoder())
modified: kiva/tests/test_gl_drawing.py
|
@jwiggins addressed your comment about the resource warnings from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving the graphics context to the PS and SVG backends raises resource warnings because the file handler is not closed by the save method. This PR fixes the issue by using open as a context manager.
For example, the resource warnings look like this on master -