-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OSX job to CI using GitHub Actions #538
Conversation
I see the following in the "Post Cache EDM packages" step of the GitHub Action in 3 of the 4 jobs.
In the fourth, I see the following
Looks like this is happening because of the way we set the |
Good point. I added the toolkit to the cache key. Though the last build won't be exercising the cache logic as it would be the first time the workflow has seen the cache key (and hence find no cache). |
I'm not sure what's going wrong but things still don't seem to be working as expected. This is what I now see for all 4 jobs in the Post Cache step -
|
I was puzzled too... but then I realized what went wrong (see this commit). It is now fixed. |
Let's not. I think it would be easier to review if they're split up into separate PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 LGTM
Closes #537
Certain components (e.g. kiva) are OSX specific and it would be convenient to developers if the tests are run by CI in an OSX environment, otherwise we rely on developers having an OSX host machine and remembering to run test suite locally.
Background: Other ETS projects are in the middle of moving CI to GitHub Actions (see Traits, TraitsUI, and Traits-Futures).
I also have separate branch where I included all the jobs we currently have in Travis/Appveyor. I decided that might be too much to review in one go. The OSX job is trivial enough so it would be more efficient to break this out. Once this gets merged, it can immediately benefit pending PRs such as #392 and #535 which have OSX specific changes.
I am happy to replace this PR with one that includes all the jobs, if the reviewer prefers.