Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated trait handlers #567

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

jwiggins
Copy link
Member

@jwiggins jwiggins commented Feb 3, 2021

Closes #433.

There's still a deprecation warning about using TraitMap, but this is coming from traits internal code, so I'm not sure anything can be done within enable.

/Users/jwiggins/.edm/envs/enable-test-3.6-pyqt5/lib/python3.6/site-packages/traits/traits.py:330: DeprecationWarning: 'TraitMap' trait handler has been deprecated. Use Map instead.
  other.append(TraitMap(map))

@jwiggins
Copy link
Member Author

jwiggins commented Feb 3, 2021

Failure seems unrelated to the changes:

Download action repository 'actions/checkout@v2'
Error: An action could not be found at the URI 'https://api.github.com/repos/actions/checkout/zipball/5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f'

@rahulporuri
Copy link
Contributor

rahulporuri commented Feb 3, 2021

@jwiggins i'm going to rerun the jobs to see if the problem fixes itself - but it'll be interesting if this happens again - Update : Looks like that fixed the CI failure.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwiggins
Copy link
Member Author

jwiggins commented Feb 3, 2021

Thanks for the review

@jwiggins jwiggins merged commit 11a5957 into master Feb 3, 2021
@jwiggins jwiggins deleted the fix/traits-deprecations branch February 3, 2021 11:59
@kitchoi
Copy link
Contributor

kitchoi commented Feb 3, 2021

There's still a deprecation warning about using TraitMap, but this is coming from traits internal code, so I'm not sure anything can be done within enable.

The deprecation warning coming from Traits is reverted as part of Traits 6.2. See enthought/traits#1365

The move from TraitPrefixMap to PrefixMap may not be possible in cases where callables are also used, see enthought/traits#1336
However I think that edge case does not apply here, so the switch here is fine.

I am sorry I should have updated #433 on that particular warning.

@jwiggins
Copy link
Member Author

jwiggins commented Feb 3, 2021

No worries @kitchoi. Thanks for adding an explanation here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning from usage of TraitPrefixList/TraitPrefixMap
3 participants