Remove the old and outdated Pyglet and VTK backends #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rahulporuri
approved these changes
Feb 5, 2021
There was a problem hiding this comment.
The changes LGTM but i'm not entirely sure what you mean by "Both backends have been mostly inaccessible since the refactor in d3aa65b (just a short 10 years ago)".
I searched for uses of the pyglet and vtk backends on github and i couldn't find any.
It might be better to have this approved by a higher authority (maybe @corranwebster , @mdickinson , @rkern )?
|
Yes. I'd prefer to hear the opinion of them before merging this. |
|
I think these backends can go. The projects that did use them are long-dormant. With the macOS deprecation of OpenGL, I think we'll probably need to start from scratch if we want this kind of functionality in the future. |
|
Thanks for the feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both backends have been mostly inaccessible since the refactor in d3aa65b (just a short 10 years ago)