Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to benchmark image outputs #653

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Add links to benchmark image outputs #653

merged 1 commit into from
Mar 2, 2021

Conversation

jwiggins
Copy link
Member

@jwiggins jwiggins commented Mar 1, 2021

Fixes #649

rahulporuri
rahulporuri reviewed Mar 1, 2021
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and it looks like 1x and 2x are swapped around - the filename says 2x but the image is actually 1x and viceversa. Never mind. I was just confused.

@rahulporuri rahulporuri self-requested a review March 1, 2021 23:41
rahulporuri
rahulporuri approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested this locally and it works as expected.

@rahulporuri
Copy link
Contributor

Is this the issue with the qpainter backend draw_rect you were referring to -
qpainter draw_rect 2x

@jwiggins
Copy link
Member Author

jwiggins commented Mar 2, 2021

Is this the issue with the qpainter backend draw_rect you were referring to

That's the one.

@jwiggins jwiggins merged commit 3fb9191 into master Mar 2, 2021
@jwiggins jwiggins deleted the feature/benchmark-images branch March 2, 2021 08:08
@jwiggins
Copy link
Member Author

jwiggins commented Mar 2, 2021

Thanks for the review

@rahulporuri
Copy link
Contributor

rahulporuri commented Mar 2, 2021 •
edited
Loading

created the issue #657 - this sounds like a blocker for switching the default backend from agg to celiagg.

@jwiggins
Copy link
Member Author

jwiggins commented Mar 2, 2021

This is a QPainter problem. Switching to celiagg wouldn't change anything

@rahulporuri
Copy link
Contributor

im sorry. im not in the right headspace right now

@jwiggins
Copy link
Member Author

jwiggins commented Mar 2, 2021

Don't sweat it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kiva Benchmark: Add links to image outputs
2 participants
@jwiggins @rahulporuri