Convert on_trait_change decorators to observe #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronayres35
commented
Mar 1, 2021
| @on_trait_change("svg_coords,mouse_in") | ||
| def ensure_redraw(self): | ||
| @observe("svg_coords,mouse_in") | ||
| def ensure_redraw(self, event=None): |
There was a problem hiding this comment.
This method and cell_properties_changed in a later file are never called standalone, but they are not privately named. So I made event a kwarg to protect against breaks from other callers, but this is likely overkill/unneeded. I am happy to change this to just event if a reviewer prefers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #416
This PR replaces all uses of the
@on_trait_changedecorator with the observe equivalent.