Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an intro section for Enable docs #658

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Add an intro section for Enable docs #658

merged 2 commits into from
Mar 2, 2021

Conversation

jwiggins
Copy link
Member

@jwiggins jwiggins commented Mar 2, 2021

Fixes #600

@jwiggins jwiggins requested a review from aaronayres35 March 2, 2021 08:39
aaronayres35
aaronayres35 approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Just one minor comment, about adding a link to html5 cavnas docs. It may not be necessary though, and if you prefer against it I'm fine if it is left out

@jwiggins
Copy link
Member Author

jwiggins commented Mar 2, 2021

I'm happy to link to the excellent MDN documentation. Done!

@jwiggins jwiggins merged commit d3abd75 into master Mar 2, 2021
@jwiggins jwiggins deleted the docs/enable-intro branch March 2, 2021 12:55
@jwiggins
Copy link
Member Author

jwiggins commented Mar 2, 2021

Thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronayres35 aaronayres35 aaronayres35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: Enable docs could use an intro section
2 participants
@jwiggins @aaronayres35