Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for CompiledPath #662

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Add documentation for CompiledPath #662

merged 2 commits into from
Mar 2, 2021

Conversation

jwiggins
Copy link
Member

@jwiggins jwiggins commented Mar 2, 2021

Fixes #614

aaronayres35
aaronayres35 approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just a few comments. I think an example inside the docs could be useful

@jwiggins jwiggins merged commit fa3aae4 into master Mar 2, 2021
@jwiggins
Copy link
Member Author

jwiggins commented Mar 2, 2021

Thanks for the feedback

@jwiggins jwiggins deleted the docs/compiled-path branch March 2, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronayres35 aaronayres35 aaronayres35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document Compiled Paths
2 participants
@jwiggins @aaronayres35