Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set encoding when writing gcbench output #671

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Set encoding when writing gcbench output #671

merged 1 commit into from
Mar 3, 2021

Conversation

rahulporuri
Copy link
Contributor

fixes #670

#666 broke gcbench on windows. The fix is to simply set encoding when writing the gcbench output.

FIX : Set encoding when writing gcbench output
778f2d0 
fixes #670

	modified:   enable/gcbench/publish.py
aaronayres35
aaronayres35 approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't confirm this fixes gcbench on windows, but nonetheless the change LGTM

jwiggins
jwiggins approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seriously? WTF Windows.

Thanks @rahulporuri!

@rahulporuri rahulporuri merged commit bcdf89a into master Mar 3, 2021
@rahulporuri rahulporuri deleted the fix/670 branch March 3, 2021 13:33
@aaronayres35 aaronayres35 mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronayres35 aaronayres35 aaronayres35 approved these changes

@jwiggins jwiggins jwiggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gcbench fails on Windows
3 participants
@rahulporuri @jwiggins @aaronayres35