Break out the font scoring methods and test them #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I went ahead and actually deleted the old methods from |
rahulporuri
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
LGTM.
I did a quick search through the enthought codebases on GitHub to see if there are any uses of the methods - and I don't see any. None whatsoever. Searching in general on GitHub raises a lot of false negatives - uses of the method on the matplotlib font manager.
I'm confident that removing the methods won't cause much (if any) pain.
Comment on lines
+22
to
+23
| # Each of the scoring functions below should return a value between | ||
| # 0.0 (perfect match) and 1.0 (terrible match) |
There was a problem hiding this comment.
bikeshed : that seems backwards to me. but i guess it also makes sense in terms of distance between fonts and 0.0 means perfect match/zero distance and 1.0 is scaled worst match/infinite distance.
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, I'm pretty sure that along with #700, I'm really done breaking things out of
kiva.fonttools.font_manager. The next PR is the big one.This PR moves the font scoring methods to their own module and covers them liberally with tests. A bug in
score_sizewas fixed (trying to call adictinstance).The font scoring methods are used by
FontManager.findfontto compareFontEntryinstances withFontPropertiesinstances to determine their similarity.