Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create a ref cycle in AbstractWindow.cleanup() #749

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Don't create a ref cycle in AbstractWindow.cleanup() #749

merged 1 commit into from
Mar 24, 2021

Conversation

jwiggins
Copy link
Member

Resolves #104

rahulporuri
rahulporuri approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This looks like the right thing to do!

@jwiggins jwiggins merged commit 3eb25d4 into master Mar 24, 2021
@jwiggins jwiggins deleted the fix/abstract-window-cycles branch March 24, 2021 11:56
@jwiggins
Copy link
Member Author

Thanks for the review

jwiggins added a commit that referenced this pull request Mar 24, 2021
@jwiggins
Don't create a ref cycle in AbstractWindow.cleanup() (#749)
03551f8
@jwiggins jwiggins mentioned this pull request Mar 24, 2021
Merged
jwiggins added a commit that referenced this pull request Mar 25, 2021
@jwiggins
Don't create a ref cycle in AbstractWindow.cleanup() (#749)
cc405d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

@aaronayres35 aaronayres35 Awaiting requested review from aaronayres35

@mdickinson mdickinson Awaiting requested review from mdickinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AbstractWindow.cleanup creates cyclic garbage.
2 participants
@jwiggins @rahulporuri