Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "ubuntu-latest" for GitHub Actions CI #865

Closed
wants to merge 1 commit into from

Conversation

rahulporuri
Copy link
Contributor

This PR updates GitHub Actions CI to use ubuntu-latest instead of older ubuntu-* versions. This is possible now as #360 has been resolved and we no longer need to pin ubuntu to older versions.

instead of older ubuntu versions

	modified:   .github/workflows/bleeding-edge.yml
	modified:   .github/workflows/test-with-edm.yml
@rahulporuri
Copy link
Contributor Author

Most of the test failures end in this way -

...

    import wx
  File "/home/runner/.edm/envs/enable-test-3.6-wx/lib/python3.6/site-packages/wx/__init__.py", line 12, in <module>
    __version__ = wx.__version__.VERSION_STRING
AttributeError: module 'wx' has no attribute '__version__'

This can be replicated offline

ModuleNotFoundError: No module named 'wx.version.VERSION_STRING'; 'wx.version' is not a package

Note that the version I was using locally was 4.1.1 - whereas we pin the version to < 4.1 in traitsui and pyface.

@rahulporuri rahulporuri removed the request for review from aaronayres35 July 7, 2021 09:55
@rahulporuri rahulporuri self-assigned this Jul 7, 2021
@rahulporuri rahulporuri deleted the cln/use-ubuntu-latest branch July 19, 2021 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant