Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QOpenGLWidget #900

Merged
merged 5 commits into from
Mar 16, 2022
Merged

Use QOpenGLWidget #900

merged 5 commits into from
Mar 16, 2022

Conversation

corranwebster
Copy link
Contributor

The QOpenGLWidget replaces the deprecated QGLWidget. The only change is that we no longer need to actively call swapBuffer.

This PR relies on #897 being merged first, since this can't be tested on Qt6 without that PR.

@corranwebster corranwebster reopened this Mar 10, 2022
@corranwebster corranwebster mentioned this pull request Mar 10, 2022
3 tasks
Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ a couple comments

enable/qt4/base_window.py Outdated Show resolved Hide resolved
kiva/gl/__init__.py Outdated Show resolved Hide resolved
@corranwebster corranwebster merged commit b9b145d into main Mar 16, 2022
@jwiggins jwiggins deleted the fix/qt6-use-openglwidget branch March 16, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants