Handle .ttf fonts with missing ulCodePageRange1
entries
#906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this happens for either very old fonts or fonts which aren't fully compliant with the open type specification. Not much either we or the user can do about it, so we just ignore - the information we want isn't there.
We could write a test if we can find a font which is missing this piece of data and has a suitable license (eg. OTL). However the only fonts I could find with this are Humor sans 1.0 which is unlicensed and MTExtra which is owned by Microsoft and which is not suitably licensed.
A reviewer can validate that this PR works by:
Fixes #882.