Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and improvements to Kiva documentation #914

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

corranwebster
Copy link
Contributor

In particular, this:

In particular, this:
- adds many lins to the API documentation
- fixes #869
- adds a stub document discussing writing new Kiva backends
Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are nice improvements

@@ -99,7 +123,7 @@ join, and cap:
Then in a loop, we draw twice (the two :py:meth:`stroke_path` calls). The first
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be ~.AbstractGraphicsContext.stroke_path

Comment on lines 319 to 320
Before filling a path, the colour of the fill is via the
:py:meth:`~.AbstractGraphicsContext.set_fill_color` method, and gradient fills
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think our documentation's spelling style of "colo[u]r" should match that of the API it's describing?

@corranwebster corranwebster merged commit a9b069f into main Mar 18, 2022
@jwiggins jwiggins deleted the doc/document-add-application-fonts branch March 18, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document "kiva.api.add_application_font"
2 participants