Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply black to the codebase #267

Merged
merged 3 commits into from
Feb 17, 2020
Merged

Apply black to the codebase #267

merged 3 commits into from
Feb 17, 2020

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Feb 17, 2020

One-time application of of black to the codebase, to clean up some of the more egregious style issues. This isn't something we expect to repeat on a regular basis.

For ease of recreation: the black version used was:

mirzakhani:envisage mdickinson$ black --version
black, version 19.10b0

And the exact command issued was:

mirzakhani:envisage mdickinson$ black --line-length 79 --target-version py35 .

No other changes were made to the codebase in this PR.

@codecov-io
Copy link

codecov-io commented Feb 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@174a7f3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #267   +/-   ##
=========================================
  Coverage          ?   53.06%           
=========================================
  Files             ?      135           
  Lines             ?     4425           
  Branches          ?      518           
=========================================
  Hits              ?     2348           
  Misses            ?     2033           
  Partials          ?       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 174a7f3...a0e1438. Read the comment docs.

Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got bored about halfway through the changes. Looks fine modulo the disagreements I have with Black's style choices.

@mdickinson mdickinson merged commit f596013 into master Feb 17, 2020
@mdickinson mdickinson deleted the exp/blacken-the-codebase branch February 17, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants