Update super usage #300
Merged
Update super usage #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
done using automated regex-based search and replace
rahulporuri
commented
Aug 26, 2020
| @@ -74,7 +74,7 @@ def _on_project_changed(self, obj, trait_name, old, new): | |||
| if new is not None: | |||
| self._update_project_listeners(new, remove=False) | |||
|
|
|||
| super(SaveAsAction, self)._on_project_changed( | |||
There was a problem hiding this comment.
ohh god looks like this path is never tested/exercised because the class name is SaveAsProjectAction and there is no SaveAsAction. It's possible that this class was called SaveAsAction earlier
There was a problem hiding this comment.
See also #269. single_project should just die
| @@ -71,7 +71,7 @@ def _on_project_changed(self, obj, trait_name, old, new): | |||
| if new is not None: | |||
| self._update_project_listeners(new, remove=False) | |||
|
|
|||
| super(SaveAction, self)._on_project_changed(obj, trait_name, old, new) | |||
There was a problem hiding this comment.
same as earlier here. The class name is SaveProjectAction, not SaveAction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See similar PR enthought/traits#1280
All of the changes were done using automated regex-based search and replace. The regex used was -
(super)+\(+(\w+)(,)+\s(self)+\)+. The changes were individually added usinggit add -p *.